Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coastal erosion notebook #485

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Fix coastal erosion notebook #485

merged 5 commits into from
Nov 8, 2023

Conversation

vikineema
Copy link
Collaborator

@vikineema vikineema commented Nov 7, 2023 •
edited
Loading

Proposed changes

  • Update the coastal module to use the correct pyTMD namespaces and functions

Checklist (replace [ ] with [x] to check off)

  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
  • Include relevant tags in the first notebook cell and re-use tags if possible
  • Ensure appropriate colour schemes have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Closes issues (optional)

  • Closes Issue #000

nanaboamah89
nanaboamah89 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@nanaboamah89 nanaboamah89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work Vicky

@vikineema vikineema merged commit 1d41e6c into main Nov 8, 2023
1 check passed
@vikineema vikineema deleted the fix-coastal-erosion-notebook branch November 8, 2023 09:32
nanaboamah89 pushed a commit that referenced this pull request Nov 13, 2024
@vikineema
Fix coastal erosion notebook (#485)
eceae75 
* update coastal module

* format using isort

* Move imports to the top of the file

* update deafrica-tools version number

* rerun the coastal erosion notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaboamah89 nanaboamah89 nanaboamah89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikineema @nanaboamah89