Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-12-18] Refactor page tree and add it to to statistics as a collapsible box #3130

Open
4 tasks
Tracked by #1097
JoeyStk opened this issue Oct 12, 2024 · 11 comments · May be fixed by #3325
Open
4 tasks
Tracked by #1097

[2024-12-18] Refactor page tree and add it to to statistics as a collapsible box #3130

JoeyStk opened this issue Oct 12, 2024 · 11 comments · May be fixed by #3325
Assignees
Labels
deadline Needs to be fixed in the given time effort: high Big change, which requires >12h enhancement This improves an existing feature feature New feature or request prio: high Needs to be resolved ASAP.
Milestone

Comments

@JoeyStk
Copy link
Contributor

JoeyStk commented Oct 12, 2024

Motivation

We want to add the access statistics for individual pages to our statistics. For this we need a collapsible box containing a replicated page tree.

Proposed Solution

Refactor page tree first and then add one instance of the page tree to the statistics page as a collapsible box.

Alternatives

None

User Story

As a user of the CMS I want to see the number of accesses to individual pages in a hierarchical way so that I know which content is more generally relevant for the majority of users.

Additional Context

This part of our meta issue #1097

Design Requirements

Design proposal (v3):
https://www.figma.com/file/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1179-830

ToDos:

  • Refactor page list view
  • New template for _generic_page_tree
  • pages_page_trree
  • statistics_page_tree
@JoeyStk JoeyStk added feature New feature or request prio: high Needs to be resolved ASAP. enhancement This improves an existing feature deadline Needs to be fixed in the given time labels Oct 12, 2024
@JoeyStk JoeyStk added this to the 24Q4 milestone Oct 12, 2024
@JoeyStk JoeyStk added the effort: high Big change, which requires >12h label Oct 22, 2024
@charludo
Copy link
Contributor

charludo commented Nov 6, 2024

Most of the issues linked in #1097 are blocked by this issue. I would therefore like to get started on it, but tbh I am kinda lost on what/how much needs to be refactored.

Is it enough to make the page tree "work" for the purpose of showing the new statistics? Or do we actually want a ground-up, modular rebuild?

Both are certainly possible, but I am struggling to see if there is a good middle ground here.

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Nov 7, 2024

Is it enough to make the page tree "work" for the purpose of showing the new statistics? Or do we actually want a ground-up, modular rebuild?

As I remember the idea was to "refactor" so much, that we can reuse as much as possible. Therefore I'm leaning towards the first. But @david-venhoff is there maybe something else you also would like to see get done with this issue? :)

@david-venhoff
Copy link
Member

No, I also think that it is enough to get the page tree to work for statistics :)

@charludo
Copy link
Contributor

charludo commented Nov 7, 2024

Alright, thanks for the clarification.

@jarlhengstmengel jarlhengstmengel self-assigned this Nov 22, 2024
@jarlhengstmengel
Copy link
Contributor

photo_5341680732348736017_y

@jarlhengstmengel
Copy link
Contributor

'@JoeyStk i merged archived_page_tree.html into page_tree.html. The page tree and the archived page tree deal with their rows quite differently, so the archived drop down of the rows has still some errors and I haven't merged the respective row templates yet

@jarlhengstmengel
Copy link
Contributor

Should we also implement a generic tree node? Would that make sense?

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Dec 22, 2024

@jarlhengstmengel
Remaining tasks:

  • Fix issue with icon
  • Fix issue with strange spacing
  • Fix issue with page tree
  • Fix issue with archived page tree (pages are sorted to the wrong parent, but probably same root)
  • Change page tree to be not editable in statistics (as for archived pages)
  • Fix issue to select a time frame
  • Fix issue to select language

@jarlhengstmengel
Copy link
Contributor

Regarding the refactoring of the archived page tree, the idea came up to show the (not archived) ancestors of a archived page so that users get a better overview where in the page tree the archived page was located. I think that could be helpful information when a page should be restored. Is that something we would like to do @JoeyStk?

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Jan 8, 2025

Regarding the refactoring of the archived page tree, the idea came up to show the (not archived) ancestors of a archived page so that users get a better overview where in the page tree the archived page was located. I think that could be helpful information when a page should be restored. Is that something we would like to do @JoeyStk?

I have wondered about something similar in the past. I assume we would need to do a good job with it and stay in touch with ui-ux during the process, but all in all I like the idea to improve the current view

@jarlhengstmengel
Copy link
Contributor

Regarding the refactoring of the archived page tree, the idea came up to show the (not archived) ancestors of a archived page so that users get a better overview where in the page tree the archived page was located. I think that could be helpful information when a page should be restored. Is that something we would like to do @JoeyStk?

I have wondered about something similar in the past. I assume we would need to do a good job with it and stay in touch with ui-ux during the process, but all in all I like the idea to improve the current view

@osmers @nikolahoff what do you think? Currently it's just a plain list of archived pages without any special structure. In the current state of refactoring, the hierarchy between a archived page and it's implicitly archived children is visible, but without the possibility of collapsing or expanding as in the page tree since that turned out to be quite complicated to realize. With showing the non archived parents, the dropdown should be a lot easier to implement, but I think that a good visual distinction would be needed

@JoeyStk JoeyStk linked a pull request Jan 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time effort: high Big change, which requires >12h enhancement This improves an existing feature feature New feature or request prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants