-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-12-18] Refactor page tree and add it to to statistics as a collapsible box #3130
Comments
Most of the issues linked in #1097 are blocked by this issue. I would therefore like to get started on it, but tbh I am kinda lost on what/how much needs to be refactored. Is it enough to make the page tree "work" for the purpose of showing the new statistics? Or do we actually want a ground-up, modular rebuild? Both are certainly possible, but I am struggling to see if there is a good middle ground here. |
As I remember the idea was to "refactor" so much, that we can reuse as much as possible. Therefore I'm leaning towards the first. But @david-venhoff is there maybe something else you also would like to see get done with this issue? :) |
No, I also think that it is enough to get the page tree to work for statistics :) |
Alright, thanks for the clarification. |
'@JoeyStk i merged |
Should we also implement a generic tree node? Would that make sense? |
@jarlhengstmengel
|
Regarding the refactoring of the archived page tree, the idea came up to show the (not archived) ancestors of a archived page so that users get a better overview where in the page tree the archived page was located. I think that could be helpful information when a page should be restored. Is that something we would like to do @JoeyStk? |
I have wondered about something similar in the past. I assume we would need to do a good job with it and stay in touch with ui-ux during the process, but all in all I like the idea to improve the current view |
@osmers @nikolahoff what do you think? Currently it's just a plain list of archived pages without any special structure. In the current state of refactoring, the hierarchy between a archived page and it's implicitly archived children is visible, but without the possibility of collapsing or expanding as in the page tree since that turned out to be quite complicated to realize. With showing the non archived parents, the dropdown should be a lot easier to implement, but I think that a good visual distinction would be needed |
Motivation
We want to add the access statistics for individual pages to our statistics. For this we need a collapsible box containing a replicated page tree.
Proposed Solution
Refactor page tree first and then add one instance of the page tree to the statistics page as a collapsible box.
Alternatives
None
User Story
As a user of the CMS I want to see the number of accesses to individual pages in a hierarchical way so that I know which content is more generally relevant for the majority of users.
Additional Context
This part of our meta issue #1097
Design Requirements
Design proposal (v3):
https://www.figma.com/file/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1179-830
ToDos:
_generic_page_tree
pages_page_trree
statistics_page_tree
The text was updated successfully, but these errors were encountered: