-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove contact data fields from poi #3180
base: develop
Are you sure you want to change the base?
Remove contact data fields from poi #3180
Conversation
Thanks! |
8a1c879
to
1919148
Compare
1919148
to
b22737a
Compare
We should merge this PR in such a timing that it will be delivered at the same time with (or after) the final release of the contact feature for all users, as this removes the contact fields from POI and they must be then shown as primary contact in the related contact box (which is currently visible only for Service Team and CMS Team). |
543cc34
to
b4e40b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening a PR 💪 I have some initial suggestions.
integreat_cms/cms/migrations/0112_remove_poi_email_remove_poi_phone_number_and_more.py
Outdated
Show resolved
Hide resolved
integreat_cms/cms/migrations/0112_remove_poi_email_remove_poi_phone_number_and_more.py
Outdated
Show resolved
Hide resolved
1f8ec2b
to
bc2b37e
Compare
bc2b37e
to
0ef376f
Compare
@MizukiTemma I am receiving test errors, is it because of the test data, specifically, the poi which should not have contact data anymore? 🤔 When I do |
@lunars97 Yes, The three fields should be removed from the POIs of the test data too. |
integreat_cms/cms/migrations/0112_remove_poi_email_remove_poi_phone_number_and_more.py
Outdated
Show resolved
Hide resolved
Remove contact box from poi form and refactor migration
0ef376f
to
fed7ff1
Compare
bd43e82
to
83b6f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much 😻
Only one suggestion left, which is actually because of the innacurate issue description 🙈 🙏
83b6f72
to
7ba539e
Compare
Short description
Remove contact box(email, phone number and website) from the poi. These fields should be managed in the contacts.
Proposed changes
Side effects
Resolved issues
Fixes: #3086
Pull Request Review Guidelines