-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop hiding the grids when POI is removed #3292
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR! I think it looks good so far 🚀
During my review I checked the following:
✔️ The PR follows the design and uses the correct wording of the design
✔️ Code is understandable to me (besides one nit and one question, see below :) )
✔️ Checking in the events form for side effects. By positive testing, I couldn't find a side effect. The next reviewer could focus on some negative testing :)
f0c5da6
to
b0c0dda
Compare
@JoeyStk Thank you for review 😸 Your suggetions are applied 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
One thing I noticed is that the grids still get hidden if the user clicks submit when the location is empty. Even though, when the user selects a location again, the previous values for the other grid items are still there.
Do you think it would make sense to also fix this?
96f9783
to
9d1e2f5
Compare
Co-authored-by: David Venhoff <david.venhoff@tuerantuer.org>
9d1e2f5
to
f4dd21c
Compare
@david-venhoff Yes 😸 patched to keep them open if any of the five fields is filled with something. |
Short description
This PR fixes the prblem that the middle and right grid are closing when a POI is removed while editing an existing contact.
Proposed changes
Side effects
Resolved issues
Fixes: #3151
Pull Request Review Guidelines