Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hiding the grids when POI is removed #3292

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Dec 12, 2024

Short description

This PR fixes the prblem that the middle and right grid are closing when a POI is removed while editing an existing contact.

Proposed changes

  • Remove code lines that close the grids whenever location is unseleted
  • Change the trash icon to pencil icon
  • Add a message indicating location is mandatory.

Side effects

  • I hope none 🙈
  • Please check for side effects in event form too

Resolved issues

Fixes: #3151


Pull Request Review Guidelines

@MizukiTemma MizukiTemma added deadline Needs to be fixed in the given time prio: high Needs to be resolved ASAP. labels Dec 13, 2024
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR! I think it looks good so far 🚀

During my review I checked the following:
✔️ The PR follows the design and uses the correct wording of the design
✔️ Code is understandable to me (besides one nit and one question, see below :) )
✔️ Checking in the events form for side effects. By positive testing, I couldn't find a side effect. The next reviewer could focus on some negative testing :)

integreat_cms/static/src/js/poi_box.ts Show resolved Hide resolved
integreat_cms/static/src/js/poi_box.ts Outdated Show resolved Hide resolved
@MizukiTemma
Copy link
Member Author

@JoeyStk Thank you for review 😸 Your suggetions are applied 👍

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

One thing I noticed is that the grids still get hidden if the user clicks submit when the location is empty. Even though, when the user selects a location again, the previous values for the other grid items are still there.
Do you think it would make sense to also fix this?

integreat_cms/cms/templates/ajax_poi_form/poi_box.html Outdated Show resolved Hide resolved
integreat_cms/static/src/js/poi-box.ts Outdated Show resolved Hide resolved
integreat_cms/static/src/js/poi-box.ts Outdated Show resolved Hide resolved
Co-authored-by: David Venhoff <david.venhoff@tuerantuer.org>
@MizukiTemma
Copy link
Member Author

One thing I noticed is that the grids still get hidden if the user clicks submit when the location is empty. Even though, when the user selects a location again, the previous values for the other grid items are still there. Do you think it would make sense to also fix this?

@david-venhoff Yes 😸 patched to keep them open if any of the five fields is filled with something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When editing a contact and removing the location it hides the other grid items
3 participants