feat: do not watch .direnv and .devenv subdirectories #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpscholten
reviewed
Jul 1, 2023
When a directory is added or removed from the root directory of the application, we start or stop watching it accordingly.
pauldub
force-pushed
the
feat-devserver-fs-improvement
branch
from
7adac3d
to
e49d955
Compare
pauldub
force-pushed
the
feat-devserver-fs-improvement
branch
from
c6ce6c4
to
8829bd4
Compare
When we stop watching a directory we do not need to test whether it is watchable or not. It being in the WatchedDirectories state is sufficient
mpscholten
reviewed
Jul 6, 2023
Sure thing, my editor setup might be messed up. |
mpscholten
approved these changes
Jul 6, 2023
|
Thanks again for the PR :) 👍 |
|
Welcome! It's a pleasure contributing to IHP. |
|
Changes here break auto reloading in my project, also using Ubuntu based distro, have to investigate. |
Was it working before this commit? It really shouldn't change anything except for the fact that we exclude a few select directories from the file watcher. Do you have large directories within your project root? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file watcher used by the dev server to automatically reload on changes seems to have issues with large directories with Ubuntu (see #1714).
The System.FSNotify API does not allow us to exclude sub-trees from the paths watched by
watchTree. Instead we can watch file changes in the root directory usingwatchDirand usewatchTreeon sub-directories excluding.direnvand.devenvwhich are known to be large directories and are not relevant with regard do reloading.We also keep track of directories added and removed from the root directory and watch them accordingly.