Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved ihp lib #1752

Merged
merged 8 commits into from
Jul 17, 2023
Merged

Improved ihp lib #1752

merged 8 commits into from
Jul 17, 2023

Conversation

mpscholten
Copy link
Member

This PR removes all of build/ihp-lib and replaces with an env var managed by devenv.

Fixes #1751

@mpscholten mpscholten merged commit b70de90 into master Jul 17, 2023
9 of 14 checks passed
@mpscholten mpscholten deleted the improved-ihp-lib branch July 17, 2023 20:30
@s0kil
Copy link
Collaborator

s0kil commented Jul 27, 2023 •
edited
Loading

Since make -B build/ihp-lib No longer works, what is the alternative when developing IHP?
Also, Contributing docs need to be updated
https://github.com/digitallyinduced/ihp/blob/master/CONTRIBUTING.md

As a workaround, I'm setting export IHP_LIB=IHP/lib/IHP in .envrc file.

@mpscholten
Copy link
Member Author

As a workaround, I'm setting export IHP_LIB=IHP/lib/IHP in .envrc file.

This is actually the solution I had in mind as well 👍

@s0kil s0kil mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace build/ihp-lib with env var
2 participants
@mpscholten @s0kil