feat(FGR distance): add integer schema with thousand separator

Co-Authored-By: Rafael Falk <rbrtrflflk@gmail.com>
Co-Authored-By: Joschka <joschka@users.noreply.github.com>

app/models/flows/fluggastrechteFormular/context.ts

@@ -20,6 +20,7 @@ import {
 } from "~/services/validation/checkedCheckbox";
 import { dateSchema } from "~/services/validation/date";
 import { timeSchema } from "~/services/validation/time";
+import { integerSchema } from "~/services/validation/integer";
 
 const FileUploadDummySchema = z.string().or(z.object({})).or(z.array(z.any()));
 
@@ -57,7 +58,7 @@ export const fluggastrechtContext = {
   ...namePrivatPerson,
   volljaehrig: YesNoAnswer,
   gesetzlicheVertretung: YesNoAnswer,
-  entfernung: z.coerce.number().min(1),
+  entfernung: integerSchema,
   teilentschaedigung: YesNoAnswer,
   frist: z.string(), // TODO: validate as German date in the future
   nebenforderungen: z.object({

app/models/flows/fluggastrechteFormular/index.ts

@@ -18,7 +18,7 @@ export const fluggastrechtFlow = {
   stringReplacements: (context: AllContexts) => {
     if (!("zwischenstopps" in context)) return {};
     return {
-      entfernung: context.entfernung?.toString(),
+      entfernung: context.entfernung?.toLocaleString("de"),
       startAirport: context.startAirport,
       endAirport: context.endAirport,
       zwischenstoppAirport: context.zwischenstoppFlughafen,

app/services/validation/integer.ts

@@ -0,0 +1,10 @@
+import { z } from "zod";
+
+export const integerSchema = z
+  .string()
+  .trim()
+  .min(1, { message: "required" })
+  .refine((numString) => /^-?(\d+|\d{1,3}(\.\d{3})+)$/.test(numString), {
+    message: "invalidInteger",
+  })
+  .transform((numString) => Number(numString.replace(/\./g, "")));

tests/unit/services/validation/integer.test.ts

@@ -0,0 +1,42 @@
+import type { SafeParseError } from "zod";
+import { integerSchema } from "~/services/validation/integer";
+
+describe("integer", () => {
+  describe("success cases", () => {
+    const cases = [
+      { input: " 100  ", expected: 100 },
+      { input: "1000", expected: 1000 },
+      { input: "1.000", expected: 1000 },
+      { input: "1.000.000", expected: 1000000 },
+    ];
+
+    test.each(cases)(
+      "given $input, returns $expected",
+      ({ input, expected }) => {
+        const actual = integerSchema.safeParse(input);
+        expect(actual).toEqual({ data: expected, success: true });
+      },
+    );
+  });
+
+  describe("failing cases", () => {
+    const cases = [
+      { input: "", errorMessage: "required" },
+      { input: "    ", errorMessage: "required" },
+      { input: "1.0", errorMessage: "invalidInteger" },
+      { input: "1000.0", errorMessage: "invalidInteger" },
+      { input: "1000,0", errorMessage: "invalidInteger" },
+    ];
+
+    test.each(cases)(
+      "given $input, returns $errorMessage",
+      ({ input, errorMessage }) => {
+        const actual = integerSchema.safeParse(input);
+        expect(actual.success).toBe(false);
+        expect(
+          (actual as SafeParseError<unknown>).error.issues[0].message,
+        ).toBe(errorMessage);
+      },
+    );
+  });
+});