refactor(reduce e2e tests against deployed app) #1586
Merged
+29
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se tests after deployment
|
1m17s opposed to ~9.5min 🤯 |
Spencer6497
force-pushed
the
e2e-tests-staging
branch
from
f48387f to
322a32a
Compare
chohner
reviewed
Jan 9, 2025
chohner
reviewed
Jan 9, 2025
playwright.config.ts
Outdated
Comment on lines
58
to
62
| name: "local-chromium", | ||
| use: { ...devices["Desktop Chrome"] }, | ||
| }, | ||
| { | ||
| name: "Mobile Android", | ||
| name: "local-mobile", |
There was a problem hiding this comment.
could we maybe call them something like full? I fear local might be missleading
There was a problem hiding this comment.
quick question: are we actually using Android here, or is this just a test with a mobile viewport? (I was on holiday and missed this info)
chohner
reviewed
Jan 9, 2025
Co-Authored-By: Spencer Peace <47868304+Spencer6497@users.noreply.github.com>
This reverts commit 5a4a343.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to save time on CI deployments by reducing the number of tests we run against the live, deployed app.