Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOV: FGR Delete formular session when user clicks "Wiederholen" #1587

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

pgurusinga
Copy link
Member

Problem

When a user clicks the wiederholen vorabcheck button, the user can change the fligt data, but this can result in stale data once they get back to the formula

Solution

  • Delete formula data when Wiederholen Vorabcheck is click and redirect to vorabcheck start page

pgurusinga and others added 2 commits January 8, 2025 16:11
Co-authored-by: aaschlote <alex.schlote@digitalservice.bund.de>
Co-authored-by: Flo Drews <florian.drews@digitalservice.bund.de>
@@ -0,0 +1,12 @@
import { type LoaderFunctionArgs, redirect } from "@remix-run/node";
import { getSessionManager } from "~/services/session.server";
//workaround to redirect to the vorabcheck result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this description?

Copy link
Contributor

@aaschlote aaschlote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jan 9, 2025

@pgurusinga pgurusinga merged commit 675d6dd into main Jan 9, 2025
21 checks passed
@pgurusinga pgurusinga deleted the delete-formular-session-on-wiederholung branch January 9, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants