Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit field to record_successful_deploy() #4056

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Add commit field to record_successful_deploy() #4056

merged 2 commits into from
Aug 5, 2020

Conversation

AliRizvi1
Copy link
Contributor

dimagi/commcare-hq#27839

Related to dimagi/commcare-hq#28234, this PR is updating the commcare-cloud code to match the new commit field in the HqDeploy model.

ENVIRONMENTS AFFECTED

Deployments will now use the --commit flag of the record_deploy_success management command automatically.

@AliRizvi1
Copy link
Contributor Author

@esoergel

esoergel
esoergel approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@esoergel esoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I think it should be safe to merge now, as the new code to accept the --commit arg will be deployed just before this is run.

@esoergel esoergel merged commit bbe0286 into dimagi:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esoergel esoergel esoergel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliRizvi1 @esoergel