Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ddtrace from local apps #5977

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

AmitPhulera
Copy link
Contributor

While looking into previous changelogs of ddtrace, I found that they have updated the way in which ddtrace should be used. Even for the version that we are using i.e 0.44.0, ddtrace can work without being configured in settings. See the changelog here

So I am creating this PR to remove ddtrace from local_apps
So removing it from staging.

Environments Affected

Staging

Copy link
Contributor

@gherceg gherceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@gherceg
Copy link
Contributor

gherceg commented Jun 1, 2023

Oh actually, is there a reason to not follow the other steps listed in that migration? Like what to do with DATADOG_TRACE configs? Looks like we use that on production

@gherceg
Copy link
Contributor

gherceg commented Jun 1, 2023

Additionally, it seems like step 3:

  1. Enable Django tracing automatically via `ddtrace-runor manually by addingddtrace.patch_all()`` to ``settings.py``.

Might be needed on staging?

@AmitPhulera
Copy link
Contributor Author

Thanks for pointing it out. I think the change for production can be added here but the settings update need to happen in commcare-hq, right?

@gherceg
Copy link
Contributor

gherceg commented Jun 2, 2023

Ah right of course! Forgot which repo we were in. I was going to ask if order of changes matters in this case (even though it is just staging), but I guess if you merge this PR, and deploy the commcare-hq changes, there will be minimal disruption since the settings changes will be applied alongside the code changes. Does that sound right?

@calellowitz
Copy link
Contributor

Is there another PR that reenables it on staging somewhere? It looks like this will just remove it from staging entirely.

@AmitPhulera
Copy link
Contributor Author

@calellowitz dimagi/commcare-hq#33186 is the link HQ PR.

@AmitPhulera AmitPhulera merged commit 570153d into master Jul 5, 2023
2 checks passed
@AmitPhulera AmitPhulera deleted the ap/remove-ddtrace-from-apps branch July 5, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants