-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ddtrace from local apps #5977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Oh actually, is there a reason to not follow the other steps listed in that migration? Like what to do with |
Additionally, it seems like step 3:
Might be needed on staging? |
Thanks for pointing it out. I think the change for production can be added here but the settings update need to happen in |
Ah right of course! Forgot which repo we were in. I was going to ask if order of changes matters in this case (even though it is just staging), but I guess if you merge this PR, and deploy the commcare-hq changes, there will be minimal disruption since the settings changes will be applied alongside the code changes. Does that sound right? |
Is there another PR that reenables it on staging somewhere? It looks like this will just remove it from staging entirely. |
3e6bfaa
to
6d8887d
Compare
@calellowitz dimagi/commcare-hq#33186 is the link HQ PR. |
While looking into previous changelogs of
ddtrace
, I found that they have updated the way in whichddtrace
should be used. Even for the version that we are using i.e 0.44.0,ddtrace
can work without being configured in settings. See the changelog hereSo I am creating this PR to remove
ddtrace
from local_appsSo removing it from staging.
Environments Affected
Staging