Add changelog for copying "Web User " Permission to "Manage Tableau Config" Permission #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snopoke
reviewed
May 17, 2024
There was a problem hiding this comment.
This seems like a bad way to deal with the limitation of custom methods on historical models.
I also doubt it will be the last time we need to do this sort of migration so I'd much prefer to see a method that allows us to do it safely in a Django migration.
See my comment on the HQ PR: dimagi/commcare-hq#34468 (review)
|
Thank you for your suggestion, I've refactored the migration so that the historical models can be used. dimagi/commcare-hq@d33d83d Closing this PR as the changelog is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR creates a migration the depends on an imported model. The historical model can not be used since the migration also depends on a custom method. Therefore, it potentially needs to be manually run.
Environments Affected
Only environments that use the TABLEAU SYNC FF
Announce New Release
to announce a new commcare-cloud release.