Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that SMTP message body is not empty #6313

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Ensure that SMTP message body is not empty #6313

merged 4 commits into from
Jun 19, 2024

Commits on Jun 7, 2024

  1. Ensure that SMTP message body is not empty 

    Email notifications of both the start of a deploy, and of a failed
deploy, have empty message bodies. Azure Communication Services rejects
emails with empty message bodies with:

> smtplib.SMTPDataError: (501, b'5.6.0 Request body validation error. Need either non-empty Html or PlainText body to be present.')
    @kaapstorm
    kaapstorm committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9694dfd View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Revert Ensure that SMTP message body is not empty 

    This reverts commit 9694dfd.
    @kaapstorm
    kaapstorm committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d46308f View commit details
    Browse the repository at this point in the history

  2. Set the subject to the message 

    Set the subject to the message because the message is short.
    @kaapstorm
    kaapstorm committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    358dcce View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Alert the dev to a potential problem

    @kaapstorm
    kaapstorm committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    19547c9 View commit details
    Browse the repository at this point in the history