Don't update sentry release in formplayer application.properties during update-config
#6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically on formplayer, the release name was being set to the current release even when doing an "update in place", resulting in an unnecessary change being made to formplayer's application.properties
stephherbers
approved these changes
Oct 1, 2024
millerdev
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/SAAS-15882
When running
update-config, we pass in"_should_update_formplayer_in_place": truehere. This variable is taken into consideration when setting _formplayer_target_dir, but not when setting sentry.release.This PR makes the change for
sentry.releaseto depend on that variable, and set it to the current release if doing an update in place to avoid unnecessary changes to this setting.sentry.release is still properly updated during formplayer deploy
Concerns
The logic to obtain the current formplayer release feels like I'm redoing work that has already been done, which makes this logic fragile to future changes to how we format how formplayer releases.
Environments Affected