Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert persistent menu auto select bug fix and related tests #1642

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

minhaminha
Copy link
Contributor

@minhaminha minhaminha commented Nov 14, 2024

Technical Summary

Jira Ticket
Reverting to fix an issue with instance('selected_cases') leading to too many cases being selected.

Reverting Persistent menu auto select fix and parts of Ensure Unique Menu Entries in Persistent Menu (only changes concerning tests)

Safety Assurance

Safety story

Tested on staging and confirmed with Delivery.

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (9db10a8) to head (6663cb0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1642      +/-   ##
============================================
+ Coverage     70.17%   70.21%   +0.03%     
  Complexity     2005     2005              
============================================
  Files           254      254              
  Lines          7902     7902              
  Branches        745      744       -1     
============================================
+ Hits           5545     5548       +3     
+ Misses         2076     2070       -6     
- Partials        281      284       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@minhaminha minhaminha merged commit 8d7841c into master Nov 14, 2024
6 checks passed
@minhaminha minhaminha deleted the revert-1638-persistentMenuAutoSelectFix branch November 14, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants