Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding an unformatted raw parameter #13

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

lulf
Copy link
Contributor

@lulf lulf commented Sep 26, 2024

This allows passing i.e. configuration data directly from network or flash without needing to parse or transform it, such as a pin number which is more a 'series of digits' than an integer.

This allows passing i.e. configuration data directly from
network or flash without needing to parse or transform it, such
as a pin number which is more a 'series of digits' than an integer.
@diondokter
Copy link
Owner

I don't have problems with this. Would you like me to release it?

Also, that new unused feature detection comes in handy again!

@diondokter diondokter merged commit b5d1b82 into diondokter:master Sep 26, 2024
3 of 4 checks passed
@lulf
Copy link
Contributor Author

lulf commented Sep 26, 2024

I don't have problems with this. Would you like me to release it?

If you don't mind, that would be much appreciated, as I have an upcoming PR to embassy using this.

@diondokter
Copy link
Owner

Done, released as 0.5.5
Apparently this crate has a yearly release schedule now :P
Third time in a row there's one release in september lol

Interesting! What part of Embassy is gonna use it? The nRF91 net?

@lulf
Copy link
Contributor Author

lulf commented Sep 26, 2024

@diondokter Originally for this PR embassy-rs/embassy#3376 - turns out I misread the documentation, the pin is quoted after all according to https://docs.nordicsemi.com/bundle/ref_at_commands/page/REF/at_commands/security/cpin_set.html 🤦 I think I looked at some unofficial code that didn't quote it or something. Apologies for spending your time on it!

@diondokter
Copy link
Owner

Oh hahaha, well the function is a fine addition to the crate!

@lulf lulf deleted the add-raw-param branch September 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants