feat: add scripts for testing in docker container #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visual Tests Report is ready. |
Without "HOME: /root" firefox crashes during testing in GitHub Actions
testing in pr-visual-tests.yml
Npm command for testing can be passed as argument for testing scripts. Mount playwright-report folder to see test results from container
Add .dockerignore to ignore node_modules folders.
martyanovandrey
approved these changes
Jan 16, 2025
playwright/Dockerfile
Outdated
| RUN npm ci | ||
| COPY . . | ||
| RUN cd demo && \ | ||
| npm i && \ |
There was a problem hiding this comment.
"npm ci" is used in ci.yml: https://github.com/diplodoc-platform/components/blob/master/.github/workflows/ci.yml#L24
With "npm i" testing in docker also works.
Change 'npm i' to 'npm ci' for demo folder
martyanovandrey
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scripts for running screenshots tests in docker container for the same tests results on different OS.
Screenshot testing results depend on the OS. For this reason, tests are run in a Docker container with Ubuntu.
How it works:
Docker builds copy of app and runs screenshot tests in container. There are mounting for components and playwright-report folders. Due to this, the results of tests (screenshots, test report) in the container also appear on the host.