-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reproject non-EBD images in WorkUnit #772
Comments
pretty sure that |
just to confirm:
I think the approach above works pretty well for most cases (i.e. checking to see if the |
If I wanted to extend the code from #770 to include non-EBD projection, what specifically would I call? Is it the general reprojection code with frame="original"? |
assuming that your |
I agreed with that approach for ra, dec. I think we will need to do something more if we want to get back original x, y though. |
WorkUnit's image_positions_to_original_icrs assumes that the images have been reprojected into EBD space and uses that information to convert the coordinates. In the future we might have cases where we have reprojected the images to a common WCS that is not in EBD space (for example if we are just combining chips into a mosaic or correcting rotation). We should have functionality to extract the correct per-image (RA, dec).
I'm guessing this can be done by: First checking hecking if we have all the EBD information
if not np.any(self.org_img_meta["per_image_wcs"] is None)
and so forth. If we have the EBD information, use that as in the current function. Otherwise, if we don't have the EBD information, do a reprojection without it.The text was updated successfully, but these errors were encountered: