fix: bad xpath expression breaks matching for everyone

src/libs/domain/matchingContext.ts

@@ -45,10 +45,15 @@ export const filterContextsMatchingUrl = (
     urlMatchesContext(url, context)
   );
 
-export const doesTabContentMatchExpression = async (tab: Tab, xpath?: string) =>
+export const doesTabContentMatchExpression = async (
+  tab: Tab,
+  xpath: string,
+  matchingContextId: MatchingContext['id']
+) =>
   xpath
     ? sendContentScriptRequest<boolean>(tab, 'doesDocumentMatchExpression', [
-        xpath
+        xpath,
+        matchingContextId
       ])
     : Promise.resolve(true);
 
@@ -57,9 +62,12 @@ export const filterContextsMatchingTabContent = async (
   matchingContexts: MatchingContext[]
 ) => {
   const responses = await Promise.all(
-    matchingContexts.map(({ xpath }: MatchingContext) =>
-      doesTabContentMatchExpression(tab, xpath)
-    )
+    matchingContexts.map(({ xpath, id }: MatchingContext) => {
+      return (
+        typeof xpath === 'undefined' ||
+        doesTabContentMatchExpression(tab, xpath, id)
+      );
+    })
   );
 
   return matchingContexts.filter((_, index) => responses[index]);

src/libs/utils/doesDocumentMatchExpression.ts

@@ -1,13 +1,27 @@
-const doesDocumentMatchExpression = (expression: string) => {
-  const { booleanValue } = document.evaluate(
-    expression,
-    document,
-    null,
-    XPathResult.BOOLEAN_TYPE,
-    null
-  );
-
-  return booleanValue;
+import { MatchingContext } from '../domain/matchingContext';
+
+const doesDocumentMatchExpression = (
+  expression: string,
+  matchingContextId: MatchingContext['id']
+) => {
+  try {
+    const { booleanValue } = document.evaluate(
+      expression,
+      document,
+      null,
+      XPathResult.BOOLEAN_TYPE,
+      null
+    );
+
+    return booleanValue;
+  } catch (error) {
+    // eslint-disable-next-line no-console
+    console.warn(
+      `[DisMoi] Could not evaluate XPath "${expression}" of matching ${matchingContextId}`
+    );
+
+    return false;
+  }
 };
 
 export default doesDocumentMatchExpression;