Update Slash Command w/o Deleting & Recreating

[civilCornball]

Hello,

For the life of me, I couldn't find a command to update an existing slash command.

So I abused $discord->http.
(Wish I could add a way to not send the PATCH request if we don't need to, though.)

Current code is this.

$discord->http->get("applications/$applicationId/guilds/$guildId/commands")->then(function ($existingCommands) use ($discord, $applicationId, $guildId, $commandsToRegister) {
        $existingByName = [];
        foreach ($existingCommands as $command) {
            $existingByName[$command->name] = $command;
        }

        foreach ($commandsToRegister as $command) {
            if (isset($existingByName[$command->name])) {
                // Update command using PATCH
                $discord->http->patch("applications/$applicationId/guilds/$guildId/commands/" . $existingByName[$command->name]->id, [
                    'name' => $command->name,
                    'description' => $command->description,
                    'options' => $command->options,
                ])->then(function () use ($command) {
                    echo "Command updated: {$command->name}\n";
                }, function ($error) use ($command) {
                    echo "Error updating command {$command->name}: {$error->getMessage()}\n";
                });
            } else {
                // Create new command using POST
                $discord->http->post("applications/$applicationId/guilds/$guildId/commands", [
                    'name' => $command->name,
                    'description' => $command->description,
                    'options' => $command->options,
                ])->then(function () use ($command) {
                    echo "Command created: {$command->name}\n";
                }, function ($error) use ($command) {
                    echo "Error creating command {$command->name}: {$error->getMessage()}\n";
                });
            }
        }
    });

Clarifying: $commandsToRegister is an array of Discord commands, filled with function calls that return the command's details.

$commandsToRegister = [
        exampleCommand($discord),
]

function exampleCommand($discord) {
    return new Command($discord, [
        'name' => 'example-command',
        'description' => 'An example command',
        'options' => [],
    ]);
}

[valzargaming]

We're in the same boat on this one. I've been doing $commands->delete($command->id) and calling $commands->save($command) just as well.

Discord's docs on this can be found at https://discord.com/developers/docs/tutorials/upgrading-to-application-commands#registering-commands however it should be noted that AbstractRepository's save function automatically calls the PATCH endpoint if the part is already created, so you shouldn't need to delete it.

There was a bug I found and patched with #1224 where if saving would return a new part with a new id it wasn't getting cached correctly, so if you were having an issue prior to this PR I would advise updating to the latest dev-main and seeing if the issue is still happening.

Please note that Guild commands should be updated almost immediately, but Global commands can take up to an hour to show the changes.

The easiest way I've found to do it is to just get the command by name:

if (! $commands->get('name', 'ping')) // Create it only if doesn't already exist, or you can ignore this line and just PATCH it anyway.
$commands->save($command);