Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix usage of react state setter #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix usage of react state setter #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/useFocusLock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export default useFocusLock;
*/
export const FocusGuard = React.memo(() => {
const [active, setActive] = React.useState(false);
useLockSubscription(setActive);
useLockSubscription((newActiveState) => setActive(newActiveState));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because useLockSubscription uses the passed-in function as a dependency in the useEffect, passing an anonymous function here means the subscription will be re-installed on every render, since it gets recreated each time.

focus-layers/src/useFocusLock.tsx

Line 23 in fbffee8

React.useEffect(() => LOCK_STACK.subscribe(callback), [callback]);

It'd be nice to memoize this first if we go this route.


return (
<div
Expand Down