UX: use group full name, add settings for description & ordering #1
+81
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
reviewed
Nov 6, 2024
| } | ||
| } | ||
| @if $capitalize-names == "true" { | ||
| &:first-letter { |
There was a problem hiding this comment.
"technically correct is the best correct" 😄
Suggested change
| &:first-letter { | |
| &::first-letter { |
| import AboutPageUsers from "discourse/components/about-page-users"; | ||
| import ConditionalLoadingSpinner from "discourse/components/conditional-loading-spinner"; | ||
|
|
||
| export default class AdditionalAboutGroups extends Component { | ||
| @service store; | ||
| @service site; | ||
|
|
| async loadGroupMembers(groupName) { | ||
| try { | ||
| const response = await fetch( | ||
| `/groups/${groupName}/members.json?offset=0&order=&asc=true` | ||
| `/g/${groupName}/members.json?offset=0&order=&asc=true` |
There was a problem hiding this comment.
I'm pretty sure those args are the default
Suggested change
| `/g/${groupName}/members.json?offset=0&order=&asc=true` | |
| `/g/${groupName}/members.json` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional request to get the full name, and optional settings for showing the group description and changing the group order.