FIX: Fix reminder frequency not getting sent daily when early by a few seconds/minutes #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Aug 10, 2023
Comment on lines
+51
to
+61
| it "enqueues a reminder if the user reminder frequency is 1 day and the last reminded at is almost 1 day" do | ||
| user.custom_fields[ | ||
| PendingAssignsReminder::REMINDERS_FREQUENCY | ||
| ] = RemindAssignsFrequencySiteSettings::DAILY_MINUTES | ||
| user.custom_fields[PendingAssignsReminder::REMINDED_AT] = 1.days.ago | ||
| user.save | ||
|
|
||
| assert_reminders_enqueued(1) | ||
| end | ||
| assign_multiple_tasks_to(user, assigned_on: 1.day.ago - 1.minute) | ||
|
|
||
| it "does not enqueue reminders if the remind frequency is set to never" do | ||
| SiteSetting.remind_assigns_frequency = 0 | ||
| assign_multiple_tasks_to(user) | ||
| assert_reminders_enqueued(1) | ||
| end |
There was a problem hiding this comment.
Non-obvious, but this is the new test for the buffer.
|
Thank you @Drenmi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t/105676
When a user sets their reminder frequency to be "daily", there's a chance that they actually only get it sent every two days.
(/my/preferences/notifications)
This is likely happening as our
EnqueueReminderssidekiq job runs every1.day, issuing a second jobRemindUserwhich updates thelast_reminded_atvalue to be a bit after the time when the sidekiq job gets done. The list of users to send reminders to depends onlast_reminded_atbeing more than the user set reminder frequency, resulting in the bug that the reminder only triggers on the next day.