DEV: Capture logs for all tests in spec/system/assign_topic_spec.rb
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this change? We have been getting flaky test failures from these specs and the failure screenshot shows that the user is not logged in when it is supposed to be. Futher investigation shows that when the test flakes, it is because the request to view the topic is using an auth token that is different from the one which was created when the user was signed in. What does this change do? 1. Add the `capture_log` metadata to all the tests in this file. 2. Enables the `verbose_auth_token_logging` site setting to give us more debugging information in the logs.
nattsw
reviewed
Jan 4, 2024
Comment on lines
+14
to
+15
| # The system tests in this file are flaky and auth token related so turning this on | ||
| SiteSetting.verbose_auth_token_logging = true |
There was a problem hiding this comment.
😿
Lol would be funny if you turn it on and it stops flaking.
nattsw
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
We have been getting flaky test failures from these specs and the failure screenshot shows that the user is not logged in when it is supposed to be. Futher investigation shows that when the test flakes, it is because the request to view the topic is using an auth token that is different from the one which was created when the user was signed in.
What does this change do?
Add the
capture_logmetadata to all the tests in this file.Enables the
verbose_auth_token_loggingsite setting to give us more debugging information in the logs.