FEATURE: Add menu to assigned text on posts #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPrigorshnev
force-pushed
the
feature/add-menu-to-assigned-text-on-posts
branch
6 times, most recently
from
e2b9912
to
065a7f8
Compare
AndrewPrigorshnev
force-pushed
the
feature/add-menu-to-assigned-text-on-posts
branch
3 times, most recently
from
009d94d
to
306a155
Compare
AndrewPrigorshnev
force-pushed
the
feature/add-menu-to-assigned-text-on-posts
branch
from
306a155
to
a5c1cbc
Compare
AndrewPrigorshnev
changed the title
AndrewPrigorshnev
force-pushed
the
feature/add-menu-to-assigned-text-on-posts
branch
from
a5c1cbc
to
e780f3e
Compare
AndrewPrigorshnev
force-pushed
the
feature/add-menu-to-assigned-text-on-posts
branch
from
e780f3e
to
f5f3475
Compare
chapoi
approved these changes
Mar 13, 2024
jjaffeux
reviewed
Mar 14, 2024
| </a> | ||
|
|
||
| <DMenu @icon="ellipsis-h" class="btn-flat more-button"> | ||
| <div class="popup-menu"> |
There was a problem hiding this comment.
Yes, we need that to style the popup menu appropriately.
There was a problem hiding this comment.
(DMenu doesn't provide that)
|
@jjaffeux, I'm ready to merge it as soon as you approve. |
jjaffeux
approved these changes
Mar 15, 2024
approved! |
AndrewPrigorshnev
deleted the
feature/add-menu-to-assigned-text-on-posts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a popup menu to assigned posts that makes it easier to unassign or reassign them:
It was pretty difficult to write the tests. I've been trying both acceptance and system specs and decided to stick with acceptance tests, though one acceptance spec is still not passing, and I skipped it for now. We'll be adding more similar menus in following PRs, and I'm going to invest more time into tests stability while working on that.
I haven't included the system specs I wrote into this PR for now (they don't pass) but we may decide to use them, let's see how adding other menus in following PRs will go.