Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Unassign label sometimes touches avatar #561

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

AndrewPrigorshnev
Copy link
Contributor

@AndrewPrigorshnev AndrewPrigorshnev commented Apr 9, 2024

We've noticed that sometimes it looks like this:

f39e0c927da766956e46387ef5d10b73052ace3e_2_1380x338

Turned out that happens when a topic has several assignments and those contain assignments to users and to groups. We don't show avatars for groups, but the code sees there are several assignees and applies overlapping styling.

I corrected the logic, and that fixed the issue.

Here is how avatars on this button behave. If there are from one to many assignments on the topic, but all the assignees are groups, we don't show avatars, only label:

Screenshot 2024-04-09 at 22 07 29

If there are from one to many assignments to the same user we show the avatar of that user (and even if there are also assignments to groups there is no overlapping):

Screenshot 2024-04-09 at 22 06 44

And if there are from two to many assignments to different users, we show avatars of first two users:

Screenshot 2024-04-09 at 22 07 11

@AndrewPrigorshnev AndrewPrigorshnev marked this pull request as ready for review April 9, 2024 18:09
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@AndrewPrigorshnev AndrewPrigorshnev merged commit 6070678 into main Apr 10, 2024
5 checks passed
@AndrewPrigorshnev AndrewPrigorshnev deleted the fix/unassign-label-touching-avatar branch April 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants