FIX: Unassign label sometimes touches avatar #561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed that sometimes it looks like this:
Turned out that happens when a topic has several assignments and those contain assignments to users and to groups. We don't show avatars for groups, but the code sees there are several assignees and applies overlapping styling.
I corrected the logic, and that fixed the issue.
Here is how avatars on this button behave. If there are from one to many assignments on the topic, but all the assignees are groups, we don't show avatars, only label:
If there are from one to many assignments to the same user we show the avatar of that user (and even if there are also assignments to groups there is no overlapping):
And if there are from two to many assignments to different users, we show avatars of first two users: