UX: adds a placeholder for signature input (#63)

The placeholder makes it clear the the field expects an URL. Also removes an un-necessary wrapping div.
discourse · Jul 24, 2024 · 6cb8032 · 6cb8032
1 parent bb5ff87
commit 6cb8032
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/...ascripts/discourse/templates/connectors/user-custom-preferences/signature-preferences.hbs b/...ascripts/discourse/templates/connectors/user-custom-preferences/signature-preferences.hbs
@@ -10,21 +10,18 @@
   </div>
   <div class="control-group signatures">
     <label class="control-label">{{i18n "signatures.my_signature"}}</label>
-    <div class="controls bio-composer input-xxlarge">
-      {{#if siteSettings.signatures_advanced_mode}}
-        <DEditor
-          @value={{model.custom_fields.signature_raw}}
-          @showUploadModal="showUploadModal"
-        />
-      {{else}}
-        <label class="text-label">
-          <Input
-            @type="text"
-            class="input-xxlarge"
-            @value={{model.custom_fields.signature_url}}
-          />
-        </label>
-      {{/if}}
-    </div>
+    {{#if siteSettings.signatures_advanced_mode}}
+      <DEditor
+        @value={{model.custom_fields.signature_raw}}
+        @showUploadModal="showUploadModal"
+      />
+    {{else}}
+      <Input
+        @type="text"
+        class="input-xxlarge"
+        placeholder={{i18n "signatures.signature_placeholder"}}
+        @value={{model.custom_fields.signature_url}}
+      />
+    {{/if}}
   </div>
 {{/if}}
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
@@ -4,3 +4,4 @@ en:
       enable_signatures: "Enable Signatures"
       show_signatures: "See user signatures below posts"
       my_signature: "My Signature"
+      signature_placeholder: "A valid URL to an image"