-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback over protocol #70
Comments
I think this is an application level concern, it should be pretty easy to display one or the other regardless of the representation that is used at the protocol level.
The rational for having it in both messages was discussed here. Depending on how we define contract information it is possible that it will change though.
ContractInfo is not really specified yet. Personally I think that each user should just get this kind of info from the oracle directly instead of receiving it from a counter party (if the info is signed by the oracle it might be ok, but still it seems like making the protocol heavier).
What do you mean by "non-discrete outcomes"? And how does the PnL representation make it easier?
Again you can see @nkohen explanation here. Personally I think at the protocol level it is easier to specify payouts as they will appear in the transaction outputs as it makes it easier to implement, but I'm open to being convinced otherwise :). |
Yes, but there is no reason to have a different model in the application from the protocol, this make things harder to implement. That said it is the approach I took for my implementation (NDLC). Also, most implementation will likely follow the model of the protocol to present things to the user (except if my implementation becomes the most used), making it the standard, and hard to reason about.
I don't know if I used the right term, but the concept of In our Trump bet, our payoff function is discrete, but in finance this is represented as a curve. (set by a few parameter) I think I should not call it |
You can have a single model, but present it in different ways. In the p2pderivatives app we show the PnL (only after contract is terminated though), which is easily computed from the collateral and output value.
I agree with having a payout function (see #81 (comment)), but I'm not sure about having a continuous function to describe discrete outcomes (or maybe I misunderstood what you mean by payout curve?). Also I also feel we shouldn't go to close to specific use cases like financial contracts at the specification levels. Again I feel this can "easily" be done at the application level. For example, some people at CG worked on a tool to generate outcomes for financial contracts: https://docs.google.com/spreadsheets/d/1nzeD2F908BEbrh6a-CsnCHKBP3PDIDO0-Djysot3RHc/edit |
The concept of PnL allow better modeling for non discrete outcomes.
Also the collateral of the accepter, even in the current protocol, is not needed.
This can be determined by the highest payout of the offer and the collateral of the offerer.
The text was updated successfully, but these errors were encountered: