Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the compilation warnings #10

Closed
diseraluca opened this issue May 20, 2021 · 1 comment · Fixed by #24
Closed

Correct the compilation warnings #10

diseraluca opened this issue May 20, 2021 · 1 comment · Fixed by #24
Assignees

Comments

@diseraluca
Copy link
Owner

diseraluca commented May 20, 2021

The are currently some compilation warning being emitted ( about 15 ).

For example:

warning: associated function is never used: `reserved21`
  --> src/session_id/message.rs:13:5
   |
13 |     reserved21: B1,
   |     ^^^^^^^^^^

warning: associated function is never used: `reserved22`
  --> src/session_id/message.rs:14:5
   |
14 |     reserved22: B1,
   |     ^^^^^^^^^^

warning: associated function is never used: `is_anonymous`
  --> src/session_id/message.rs:16:5
   |
16 |     is_anonymous: bool,
   |     ^^^^^^^^^^^^

Most of those depend on unused fields in the modular-bitfield generated structure and should be resolvable by restricting the code generation of setters and getters.

@diseraluca diseraluca self-assigned this May 20, 2021
@diseraluca diseraluca changed the title Correct the compilation warning Correct the compilation warnings May 20, 2021
@diseraluca
Copy link
Owner Author

diseraluca commented May 20, 2021

Currently blocked by Robbepop/modular-bitfield#66.

As no answer was given after about a week it was chosen to fork the library to move the issue forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant