Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added v3.0.1 with update.sh script #161

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

donstephan
Copy link
Contributor

./update.sh --meteor-version 3.0.1 --node-version 20.15.1

Meteor 3.0.1 released (no 3.0.0) in reference to forum post: https://forums.meteor.com/t/its-official-meteor-3-0-official-release-is-out/61860

donstephan added a commit to donstephan/meteor-base that referenced this pull request Jul 24, 2024
This fixes tests for PR disney#161. The test.sh file did not handle swapping in the node image maintained by meteor for version 14.21.4.
GeoffreyBooth pushed a commit that referenced this pull request Jul 24, 2024
* fix broken test.sh node image replacement logic

This fixes tests for PR #161. The test.sh file did not handle swapping in the node image maintained by meteor for version 14.21.4.

* revert whitespace

* missed a new line
@GeoffreyBooth
Copy link
Collaborator

Does this need a rebase now that the other PR has landed?

@donstephan
Copy link
Contributor Author

Yes to rerun the tests. Tests passing now. Thank you.

@GeoffreyBooth GeoffreyBooth merged commit d119ae3 into disney:main Jul 25, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants