Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deprecated virtfs options #127

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Rename deprecated virtfs options #127

merged 1 commit into from
Sep 4, 2023

Conversation

knuton
Copy link
Member

@knuton knuton commented Sep 1, 2023

Renames done following the warnings observed when running the PlayOS QEMU VM.

Checklist

  • Changelog updated
  • Code documented
  • User manual updated

@knuton
Rename deprecated virtfs options
dd226b8 
Renames done following the warnings observed when running the PlayOS
QEMU VM.
@knuton knuton added the reviewable Ready for initial or iterative review label Sep 1, 2023
guyonvarch
guyonvarch approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@guyonvarch guyonvarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, I see warnings, and with the followin changs, they are gone. 👍

@guyonvarch guyonvarch merged commit c58d82b into dividat:develop Sep 4, 2023
1 check passed
@guyonvarch guyonvarch removed the reviewable Ready for initial or iterative review label Sep 4, 2023
@knuton knuton deleted the rename-deprecated-virtfs-options branch September 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyonvarch guyonvarch guyonvarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knuton @guyonvarch