Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessible captive portal when settings are open #135

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Accessible captive portal when settings are open #135

merged 6 commits into from
Sep 8, 2023

Commits on Sep 8, 2023

  1. Give access to captive portal when on settings 

    Previously, when the settings modal was open, when a captive portal was
detected, we showed a header with a button, but it could not be
interacted with, because the modal didn’t allow to access the parent
window.

Setup the settings modal to be modeless, so that the button to open the
captive portal is still accessible.

Also better represent the dialog state with an enumeration.

See https://trello.com/c/wcIrvEau/1445-captive-portal-prompt-pops-up-beneath-controller-modal
    @guyonvarch
    guyonvarch committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8fb49c5 View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @guyonvarch
    guyonvarch committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    546b63e View commit details
    Browse the repository at this point in the history

  3. Remove unused leftover

    @guyonvarch
    guyonvarch committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1469ed8 View commit details
    Browse the repository at this point in the history

  4. Represent dialog as ADT 

    Requires Python 3.10, but this should be OK with our migration to
nixpkgs 23.05, which uses Python 3.10 by default.
    @guyonvarch
    guyonvarch committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    cd56a65 View commit details
    Browse the repository at this point in the history

  5. Remove unused enum import 

    Co-authored-by: Johannes Emerich <johannes@emerich.de>
    @guyonvarch @knuton
    guyonvarch and knuton committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8df1405 View commit details
    Browse the repository at this point in the history

  6. Focus settings when opening dialog

    @guyonvarch
    guyonvarch committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    927acef View commit details
    Browse the repository at this point in the history