-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fake popups instead of system popups #144
Conversation
This will allow us to use only one webview, and to decorate it or not with a dialog, instead of using multiple webviews.
This allows to provide show and hide method, while still preserving the position of the widget in the tree. Otherwise, when hiding an element, it’s removed from the tree.
Using popups, it was hard to test the kiosk without setting up PlayOS VM. Aditionally: - use only one webview, - decorate as dialog when necessary,
f2b9c52
to
b59200e
Compare
Adapting the last commit message, wrongly saying it was not possible to open the captive portal when settings was open, as this OK on |
|
We should expect no difference, as the proxy is set application wide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked
- proxy on shed stick,
- captive portal on shed stick,
- captive portal banner can be interacted with if config dialog is visible,
- key combos (Ctrl-Shift-F12, Esc) on shed stick work,
- kiosk running as one window on dev machine.
Nice 👍
@guyonvarch If I understand the question correctly, there should be no change and therefore no new issue in the interaction between proxy and captive portal checks. Feel free to merge if you agree, or let me know if there is another angle that I may be missing. |
Exact. One difference from before is that we take care of authentication for the captive portal as well: I think it makes more sense now than before, as before we setup the proxy, but it would have failed if it required auth for the captive portal. |
Using popups, it was hard to test the kiosk without setting up PlayOS VM.
Aditionally:
There should be no visual changes.
See https://trello.com/c/SJNLN2OJ/1550-playos-dialog-less-settings-and-captive-portal
Tests
Checklist
[ ] Changelog updated[ ] User manual updated