Switch to main and release branches #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knuton
reviewed
Dec 8, 2023
build
Outdated
| @@ -3,20 +3,14 @@ set -euo pipefail | |||
|
|
|||
| TARGET="${1:-default}" | |||
|
|
|||
| scripts/info-branch-commit | |||
| export readonly TARGET=$(scripts/option-prompt "Select a target" vm develop validation master lab-key shed-key stuck default) | |||
There was a problem hiding this comment.
all is quite good, but maybe not as precise to default, as it picks default values as well. Do you think it’s still relevant with the last change reverting to previous usage?
knuton
reviewed
Dec 8, 2023
build
Outdated
| @@ -3,20 +3,14 @@ set -euo pipefail | |||
|
|
|||
| TARGET="${1:-default}" | |||
|
|
|||
| scripts/info-branch-commit | |||
| export readonly TARGET=$(scripts/option-prompt "Select a target" vm develop validation master lab-key shed-key stuck default) | |||
There was a problem hiding this comment.
I am not necessarily against an interactive script, but I wouldn't want that to be the only option, because
- I want to be able to script things,
- I want to be able to run a combined command like
./build vm; result/bin/run-in-vmfrom history without having to type extra stuff into the terminal.
It would be fine for ./build to prompt a target if none is given, I think?
There was a problem hiding this comment.
I agree, this would not be convenient for me as well, reverting to previous usage in 9048ca6.
Adding info & confirm safeguards for develop, validation and master builds.
Only add info & confirmation steps for builds on: - develop, - validation, - release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits to simplify branch management.