Add key combo for hard refresh in kiosk #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoeffel
approved these changes
Dec 21, 2023
Add a conventional key combination to perform a hard refresh, useful for recovering if corrupted assets end up being cached. By using the Ctrl-Shift-R combination common in browsers for Windows and Linux, this may be discoverable by a savvy admin without the need to be told explicitly.
knuton
force-pushed
the
kiosk-hard-reload
branch
from
3de53c3
to
aa0efc8
Compare
guyonvarch
reviewed
Dec 22, 2023
guyonvarch
added
changes suggested
I saw something similar, though I thought it only happened when I was using the debug connection and concluded it was due to that. I can recheck whether it also happens when DevTools are not connected. |
I just checked and got the same problem without dev tools being open. |
This works around the race condition described in https://bugreports.qt.io/browse/QTBUG-111541 by waiting an instant after triggering the clearing of profile cache. If a load is triggered while the clearing is not finished, it can cause the load to hang. This can be recovered from by triggering a simple reload, but is better to avoid. A signal for observing the progress of cache clearing should be available for future versions of Qt 6: qt/qtwebengine@3743002 I considered adding a more involved mechanism to detect stalled loads and automatically trigger a new load, but concluded that a sleep should be overall simpler and easy enough to understand. As a relatively short sleep is chosen to avoid user confusion, this may still fail, but a hanging load is relatively harmless and should be recoverable by the user.
Thanks for catching this! Workaround and explanation in 6cc13db. |
knuton
added
reviewable
guyonvarch
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a conventional key combination to perform a hard refresh, useful for recovering if corrupted assets end up being cached. By using the Ctrl-Shift-R combination common in browsers for Windows and Linux, this may be discoverable by a savvy admin without the need to be told explicitly.
Testing
I started the kiosk with a debug port, opened
chrome://inspectand checked that performing a hard refresh causes files to be downloaded again. This was made easier by simulating a slow network in the debug session DevTools.Checklist