Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key combo for hard refresh in kiosk #147

Merged
merged 3 commits into from
Jan 4, 2024

Commits on Dec 21, 2023

  1. Add key combo for hard refresh in kiosk

    Add a conventional key combination to perform a hard refresh, useful for
    recovering if corrupted assets end up being cached. By using the
    Ctrl-Shift-R combination common in browsers for Windows and Linux, this
    may be discoverable by a savvy admin without the need to be told
    explicitly.
    knuton committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    aa0efc8 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    e68cb1c View commit details
    Browse the repository at this point in the history
  2. Add workaround for Qt race condition

    This works around the race condition described in
    https://bugreports.qt.io/browse/QTBUG-111541 by waiting an instant after
    triggering the clearing of profile cache. If a load is triggered while
    the clearing is not finished, it can cause the load to hang. This
    can be recovered from by triggering a simple reload, but is better to
    avoid.
    
    A signal for observing the progress of cache clearing should be
    available for future versions of Qt 6:
    qt/qtwebengine@3743002
    
    I considered adding a more involved mechanism to detect stalled loads
    and automatically trigger a new load, but concluded that a sleep should
    be overall simpler and easy enough to understand. As a relatively short
    sleep is chosen to avoid user confusion, this may still fail, but a
    hanging load is relatively harmless and should be recoverable by the
    user.
    knuton committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6cc13db View commit details
    Browse the repository at this point in the history