Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using the kiosk on platforms without DBus #159

Closed
wants to merge 3 commits into from
Closed

Allow using the kiosk on platforms without DBus #159

wants to merge 3 commits into from

Commits on May 24, 2024

  1. Fix nix-shell --run 

    Executing another bash inside the shell hook seems to break running
commands with `nix-shell --run`, something we assumed to work in the CI
configuration.

It seems that the Qt wrapper is already set up at least in modern
Nixpkgs, so we can simply remove the code for spawning the wrapped bash.
    @knuton
    knuton committed May 24, 2024
    Configuration menu
    Copy the full SHA
    810c5dd View commit details
    Browse the repository at this point in the history

  2. Add kiosk smoke test for secondary platforms

    @knuton
    knuton committed May 24, 2024
    Configuration menu
    Copy the full SHA
    af698b9 View commit details
    Browse the repository at this point in the history

  3. Allow using the kiosk on platforms without DBus 

    We previously added support for using the kiosk without connman
installed, but it still crashed when started on systems without DBus
(i.e. any non-Linux platform).

With this change we add a stub implementation of the core proxy
abstraction, which is going to provide safe no-op responses on non-Linux
platforms, allowing to use the kiosk, albeit without proxy support.
    @knuton
    knuton committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6e125e8 View commit details
    Browse the repository at this point in the history