Use tagged version of focus-shift #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This indicates more in the face which version of focus-shift we are using. This also upgrade `focus-shift` with the following change: - Ignore non-rendered elements We could think about using `nix` to pull the dependency, but as this may not be updated that much, and as we have only this dependency, keep it simple for now?
knuton
reviewed
Sep 23, 2024
controller/dune
Outdated
| @@ -4,7 +4,7 @@ | |||
| (Changelog.html as Changelog.html) | |||
| (gui/reset.css as static/reset.css) | |||
| (gui/style.css as static/style.css) | |||
| (gui/vendor/focus-shift.js as static/vendor/focus-shift.js) | |||
| (gui/vendor/focus-shift-1-0-0.js as static/vendor/focus-shift.js) | |||
There was a problem hiding this comment.
Is there an issue with using the version number in the filename, 1.0.0?
There was a problem hiding this comment.
Do you mean focus-shift-1.0.0.js for example? I think this sould work as well.
I was not certain it was a good idea, because it looks like an extension, but in the other hand, it gets further away from the version.
There was a problem hiding this comment.
Yes, exactly. I think this is the conventional way, and therefore more easily recognized as a version number.
We use this same naming pattern for the ISOs here:
Lines 115 to 120 in 5f6bfb6
knuton
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indicates more in the face which version of focus-shift we are using.
This also upgrade
focus-shiftwith the following change:We could think about using
nixto pull the dependency, but as this may not be updated that much, and as we have only this dependency, keep it simple for now?