Change active VTE restriction implementation to a xmodmap script #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script
It was very annoying to wait for xorg to be rebuilt just to make this
small restriction, so I had to shave this yak. Perhaps not the most
elegant approach, but it works and avoid needless re-compilation.
Easier to maintain and more "pluggable" as well.
Manually tested via `run-in-vm` and QEMU's sendkey. Ctrl+Shift+F12
continues to work. As before, Ctrl+Alt+F8 + Ctrl-Alt+F{N} is a hack to
"escape" the restriction.
This could actually be limited at the VTE/kernel level as well in
a similar way using something like
dumpkeys | grep .. Console_{N} .. | sed .. | loadkeys
but not sure we want that.
knuton
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was very annoying to wait for xorg to be rebuilt just to make this small restriction, so I had to shave this yak. Perhaps not the most elegant approach, but it works and avoid needless re-compilation. Easier to maintain and more "pluggable" as well.
Manually tested via
run-in-vmand QEMU's sendkey. Ctrl+Shift+F12 continues to work. As before, Ctrl+Alt+F8 + Ctrl-Alt+F{N} is a hack to "escape" the restriction.This could actually be limited at the VTE/kernel level as well in a similar way using something like
but not sure we want that.
Checklist