Open settings with a long press on the Menu key

[guyonvarch]

Demo

2024-09-24_10-55-16.mp4

Using https://github.com/dividat/diviapps/pull/2161 locally, pressing the Menu key with a short press first, and then pressing the Menu key with a long press.

Limitations

Fixed by 891c1d5.

Keeping the long press longer after the settings have been shown, it will trigger again after the delay the settings toggle. For some reason, we get a release signal, followed by a Press signal, after we toggle the settings.

2024-09-24_10-55-59.mp4

Checklist

• Changelog updated
• Code documented
• User manual updated

[knuton]

Keeping the long press longer after the settings have been shown, it will trigger again after the delay the settings toggle. For some reason, we get a release signal, followed by a Press signal, after we toggle the settings.

Not sure I understand the problem yet, but maybe detect and ignore auto repeats? https://doc.qt.io/qt-5/qkeyevent.html#isAutoRepeat

[guyonvarch]

Not sure I understand the problem yet, but maybe detect and ignore auto repeats? https://doc.qt.io/qt-5/qkeyevent.html#isAutoRepeat

Good idea, this fixes it: 891c1d5

[knuton]

This change brings another side-effect: When pressing Ctrl-C in the terminal from which I launched the kiosk browser, I now get what looks like a crash.

^CTraceback (most recent call last):
  File "/home/emerij/Development/playos/kiosk/kiosk_browser/main_widget.py", line 85, in eventFilter
    def eventFilter(self, source, event):

KeyboardInterrupt
Aborted (core dumped)

Previously the Ctrl-C was ignored.

[guyonvarch]

Previously the Ctrl-C was ignored.

We could continue to ignore Ctrl-C, which can be done with:

# Prevent closing the Kiosk with SIGINT https://stackoverflow.com/a/842807
signal.signal(signal.SIGINT, signal.SIG_IGN)

[knuton]

I think we could also change it to exiting, but gracefully instead of crashing.

[guyonvarch]

I think we could also change it to exiting, but gracefully instead of crashing.

a8a3553

[knuton]

⚡