Misc QEMU usage nitpicks #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nixosTest` is to-be-depercated, see here:
NixOS/nixpkgs#293891
qemu man pages list all options with a single dash, the double dash seems to be implicitly accepted, but not documented.
Not sure how this worked earlier, maybe earlier versions of QEMU assumed raw by default?
3 tasks
knuton
approved these changes
Sep 24, 2024
Comment on lines
+86
to
+87
| QEMU_IMG, 'create', '-f', 'qcow2', '-b', disk, '-F', 'raw', | ||
| temp + "/disk-overlay.qcow2" |
There was a problem hiding this comment.
Yes, this seems to have changed: https://progress.opensuse.org/issues/98117
Another option would be backing_file={},backing_format=raw.
But this is probably better, using the surface-level parameters to create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids using (to-be) deprecated or undocumented flags / functions and explicitly specifies the overlay format.
cc @knuton
Checklist