-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve install device selection in installer #182
Conversation
P.S. I was "inspired" to do this PR because I was running qemu with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few minor suggestions.
- Look for "/iso" mount not only in children of blockdevices, but top-level devices too (e.g. this happens when running qemu with `-cdrom playos-installer-<..>.iso`) - Eliminate devices that are too small or read-only from potential installation targets.
f2b1d14
to
fc86dec
Compare
Resolved all the comments, tested manually by adding additional disks and checking that it picks the right one based on size:
(Note: Installer medium is not identified because I am running via nix |
Did the following additional sanity checks on physical machine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👌
-cdrom playos-installer-<..>.iso
)cc @knuton
Checklist