Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable divviup-ts tests once divviup-ts implements DAP-13 #3479

Open
branlwyd opened this issue Nov 12, 2024 · 0 comments
Open

Re-enable divviup-ts tests once divviup-ts implements DAP-13 #3479

branlwyd opened this issue Nov 12, 2024 · 0 comments

Comments

@branlwyd
Copy link
Member

#3469 disabled divviup-ts tests, because there are breaking client changes between DAP-09 & DAP-13 and divviup-ts does not yet implement DAP-13.

We should update divviup-ts to implement DAP-13, and re-enable these tests with an updated container image.

pub fn divviup_ts() -> InteropClient {
is the right place to update the container image once it is available.

branlwyd added a commit that referenced this issue Nov 12, 2024
Until divviup-ts has a DAP-13 implementation, there is no way these
tests will work. I filed #3479 to track re-enablement of divviup-ts
tests.
branlwyd added a commit that referenced this issue Nov 13, 2024
Specifically:
* Use POST rather than PUT for report uploads.
* Use GET rather than POST for collection job polling.

Also, disable divviup-ts integration tests:

Until divviup-ts has a DAP-13 implementation, there is no way these
tests will work. I filed #3479 to track re-enablement of divviup-ts
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant