-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable integration tests with Daphne Helper #3030
base: main
Are you sure you want to change the base?
Conversation
Also, remove code for testing against Daphne running locally.
@@ -10,11 +10,11 @@ use serde_json::json; | |||
use testcontainers::{clients::Cli, GenericImage, RunnableImage}; | |||
use url::Url; | |||
|
|||
const DAPHNE_HELPER_IMAGE_NAME_AND_TAG: &str = "cloudflare/daphne-worker-helper:sha-f6b3ef1"; | |||
const DAPHNE_HELPER_IMAGE_NAME_AND_TAG: &str = "cloudflare/daphne-worker-helper:sha-4c612db"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note: This tag was created manually. It matches the commit that was checked out when the image was built. In the future we will add publishing the container to CI.
@branlwyd can you take a look at the CI failure? It's a bit cryptic: |
It actually failed a test further above--this job step just fails the job if a failure as detected earlier. The true error is here https://github.com/divviup/janus/actions/runs/8744950821/job/23999640943?pr=3030#step:14:411, where it complains:
n.b. I think the second |
The actual error message is a couple steps above,
Unpacking the image, I see that both |
Ah, nice find. Yeah if you built it locally with |
I don't think it would be worth hardcoding a target in the Dockerfile, since the whole base image needs to match the architecture as well, and whatever (docker-)machine is used for building needs to be able to run that architecture. |
Ah right, Rust cross-compilation is not as fool-proof as I had hoped, you still need a platform-specific linker. |
Partially addresses #2389.
Also, remove code for testing against Daphne running locally.