Update HTTP verbs for DAP-13. #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #3436. |
branlwyd
force-pushed
the
bran/dap-13-http-verbs
branch
from
e44668c
to
e039485
Compare
Specifically: * Use POST rather than PUT for report uploads. * Use GET rather than POST for collection job polling.
branlwyd
force-pushed
the
bran/dap-13-http-verbs
branch
from
e039485
to
dccd082
Compare
Until divviup-ts has a DAP-13 implementation, there is no way these tests will work. I filed #3479 to track re-enablement of divviup-ts tests.
|
I also disabled divviup-ts tests, as they're not going to work until both Janus & divviup-ts are updated to implement DAP-13. I filed #3479 to track re-enabling these tests. |
divergentdave
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically: