Remove max_batch_size parameter from leader-selected tasks. #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter was removed in DAP-12, and we do not have any reason to keep it as functionality over-and-above what is specified in DAP, so we remove this parameter from Janus. The aggregation job creator will now always create batches which are exactly min_batch_size, matching previous functionality if max_batch_size was unspecified.
|
Part of #3436. |
inahga
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter was removed in DAP-12, and we do not have any reason to keep it as functionality over-and-above what is specified in DAP, so we remove this parameter from Janus. The aggregation job creator will now always create batches which are exactly min_batch_size, matching previous functionality if max_batch_size was unspecified.