Skip to content

Commit

Permalink
revert type hint to typing.List (#1493)
Browse files Browse the repository at this point in the history
* revert type hint to `typing.List`

#1492

* Update test.yml to respect py 3.8

* Update test.yml to exclude py3.8/3.9 w/ dj50 in tests

* Update CHANGELOG.rst

* Bump version to 3.2.1

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>
  • Loading branch information
defgsus and fsbraun committed Sep 5, 2024
1 parent 250bd03 commit b38ef8f
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 3 deletions.
11 changes: 10 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.10', '3.11', '3.12']
python-version: [3.8, 3.9, '3.10', '3.11', '3.12']
requirements-file: [
django-4.2.txt,
django-5.0.txt,
Expand All @@ -18,6 +18,15 @@ jobs:
os: [
ubuntu-20.04,
]
exclude:
- requirements-file: django-5.0.txt
python-version: 3.8
- requirements-file: django-5.0.txt
python-version: 3.9
- requirements-file: django-main.txt
python-version: 3.8
- requirements-file: django-main.txt
python-version: 3.9

steps:
- uses: actions/checkout@v1
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
CHANGELOG
=========

3.2.1 (2024-09-05)
==================

* fix: Restore python 3.8 and python 3.9 compatibility

3.2.0 (2024-08-23)
==================

Expand Down
2 changes: 1 addition & 1 deletion filer/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
8. Publish the release and it will automatically release to pypi
"""

__version__ = '3.2.0'
__version__ = '3.2.1'
2 changes: 1 addition & 1 deletion filer/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def clear_folder_permission_cache(user: User, permission: typing.Optional[str] =
cache.delete(get_folder_perm_cache_key(user, permission))


def update_folder_permission_cache(user: User, permission: str, id_list: list[int]) -> None:
def update_folder_permission_cache(user: User, permission: str, id_list: typing.List[int]) -> None:
"""
Updates the cached folder permissions for a given user and permission.
Expand Down

0 comments on commit b38ef8f

Please sign in to comment.