Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md should be moved to github repo's readme or should be linked to in the docs? #207

Open
TimothyMalahy opened this issue Jan 4, 2025 · 2 comments

Comments

@TimothyMalahy
Copy link
Member

Sorry if this should be filed as a Feature request - didn't feel like the right fit.

Since I was just accepted into django-commons I figured I should take a look at the issues and see if I can help. So I decided to take a stab at #193 - which Cunla noted
It emphasizes the importance of removing the dependency on RQ in this package.

So I thought I would at least try to see what it would take to map the connections and see what I can do about it.

However - it took me awhile to find CONTRIBUTING.md I only really found it by going into my vscode and searching for "contrib"

So I was thinking it should either be added into the docs as a sidebar or it should be on the front of the github repo.

-- Still gonna go take a look at the issue at hand, but just some thoughts I had on this.

@cunla
Copy link
Member

cunla commented Jan 4, 2025

Hi @TimothyMalahy,

Thanks for noticing. Can you please create a PR to move it?

Re:RQ dependency

I started working on removing the RQ dependency - I have a branch for it, it is not as straight-forward and requires some effort.

I am happy to work on it together - I think it will require syncing on the different tasks involved and having some significant testing done.

@TimothyMalahy
Copy link
Member Author

I agree on the RQ dependency. Got a little in over my head haha. and will do for the contributing notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants