Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mb-3 from the floating fields #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JobvDijke
Copy link

You can otherwise not overwrite this display setting as it uses !important

You can otherwise not overwrite this display setting as it uses !important
@abe-101
Copy link

abe-101 commented Nov 21, 2022

@JobvDijke My understanding is that "mb-3" is part of the magical look that crispyforms give your forms
Removing from the defualt is therefore not a good idea

@smithdc1 suggested #74 (comment) we put "mb-3" in the else clause of the wrapper_class
This would give an option to override it
In PR #128 I've implemented like he suggested

@xadium
Copy link

xadium commented May 22, 2023

I've commented on the PR but this is still open and the PR was closed due to the HEAD branch being deleted.

#128 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants