Added js controls logic - control prepend or append for comments

[rosscdh]

Added js controls logic which is backwards compatible but allows is_reversed to be specified

[vdboor]

Hi! This is a neat feature to have, I like adding it.

There are a few things I'd prefer to see updated though:

• Give a different name to COMMENT_CONTROLS. Perhaps something like FLUENT_COMMENTS_SETTINGS (or config) or even <div id="comments" data-comments-reversed="true">). COMMENT_CONTROLS is too vague imho.
• Would it be possible to automatically include this setting value via the template tags, or is that information not available at that point?

Thanks for your time, and thanks in advance for looking at these points.

[rosscdh]

Hey there, sure no problem; thanks for the nice app that plugs neatly in :) 💯

1. I considered implementing it using data-* and probably still should so that the user can override the actual template.
   1. for my use-case I didnt want to have to override the template, and rather just modify direction based on the JS var.
2. I have already created (in my project) another template tag called *_reveresed which I am happy to contribute to fluent_comment. Using that it will then inject the is_reversed variable as a data-is_reversed and return the queryset in the reverse order

My pleasure :)
Ross Crawford-d'Heureuse

[vdboor]

Out of curiosity, why the explicit === true ?

[rosscdh]

I was working on the assumption that if the user enters "false" it will evaluate as true.
var test = {};
test.item = 'false'
"false"
if (test.item) { console.log('yay') }

[vdboor]

Hi, I've made some additional comments in the diff. Let me know what you think of these! I hope you don't mind a critical look here.

[rosscdh]

Hi there Diederik, of course not :) critical comments are welcome! if were gonna release something we had better make sure its more than just "ok".

I'm a touch busy atm but will give this a closer look soon!

[euanlau]

Before adding more features, is it better to rewrite the thing to a proper jQuery plugin? Actually I filed an issue #23 just for that.
Right now we have to modify ajaxcomments.js itself in order to customize the behavior.
It would be much better to have something like this:

$('div.comments-container').fluentcomments({
    append: true,
    scrollToComment: false,
});

[vdboor]

I totally agree on that one @euanlau! Nice idea. It would also make the new multi-form support (currently in master) easier to use.